launchpad

a_bach · 27-03-2010 14:56:25

I was trying to add new bug in launchpad.

Unexpected form data

Launchpad doesn't understand the form data submitted in this request.

Bug is about: theme_pagetitle sometimes dont return valid title in subpages. Create 'das' supage. It will show as instead of 'das'.

Last edited by a_bach (27-03-2010 14:57:46)

a_bach · 27-03-2010 15:16:03

I think

$page_title = trim(implode(' &middot; ', $titles));

instead of

 foreach ($titles as $title)
				$final_title .=  ' &middot; '.$title;

			$page_title = ltrim($final_title, '&middot; ');

in get_pagetitle() will do the job.

One more think:

function theme_sitetitle() {
	echo SITE_TITLE;
}

So why dont delete this function and in theme.php type:

<?php echo SITE_TITLE; ?>

Sander · 31-03-2010 13:26:29

a_bach wrote:

One more think
function theme_sitetitle() {
echo SITE_TITLE;
}
So why dont delete this function and in theme.php type:
<?php echo SITE_TITLE; ?>

I think it's better to keep that as it is now, for backward compatibility with older themes. If we delete the function, al lot of custom themes will break in the next version.

About the other fix you mention; if you've tested it thouroughly, I think you can commit the fix to the main branch.

a_bach · 07-04-2010 09:15:50

Sander wrote:

I think it's better to keep that as it is now, for backward compatibility with older themes. If we delete the function, al lot of custom themes will break in the next version.
About the other fix you mention; if you've tested it thouroughly, I think you can commit the fix to the main branch.

Fix commited.

And I was thinkig about functions... So dont delete those function, but start using prefefined variables in new themes.

A_Bach

pluck support forums

Announcement

#1 27-03-2010 14:56:25

launchpad

#2 27-03-2010 15:16:03

Re: launchpad

#3 31-03-2010 13:26:29

Re: launchpad

#4 07-04-2010 09:15:50

Re: launchpad

Board footer