pluck
pluck 4.7 out now, download it today!

pluck support forums

for all your questions about the easiest CMS on the planet

You are not logged in.

Announcement

New registrations are disabled for some spam problems. New registrations will be avaliable soon. If you want to help to keep forum away from spam - contact us.
Please post your bug reports on Launchpad.

Pages: 1

#1 12-10-2011 21:38:26

miks
Member
Registered: 11-01-2009
Posts: 57
Website

Blog module affected by modified seo module

I could not use the stock seo module, something related to the server setup. (thread here)
As you will see from that thread, a_bach solved the problem with some modified files, and now seo works fine.  The point of this post is that if I insert a photo into a blog post and align it to the right, it does not show on the blog post, it only shows an image icon.  The testbed site is HERE
This problem only occurs if I am using the modified blog module.  Any ideas what could be causing this?

Offline

#2 13-10-2011 05:50:47

a_bach
developer/module guru
From: Poland
Registered: 24-11-2008
Posts: 439
Website

Re: Blog module affected by modified seo module

It seems you dont have this code:

function seo_theme_content($content) {
	if (is_apache_module()) {
		$content = str_replace('href="?file=', 'href="'.SITE_URL.'/', $content);
		$content = str_replace('src="images/', 'src="'.SITE_URL.'/images/', $content);
	}
	return $content;
}

Inside seo.php file.

Offline

#3 13-10-2011 08:42:15

miks
Member
Registered: 11-01-2009
Posts: 57
Website

Re: Blog module affected by modified seo module

a_bach wrote:

It seems you dont have this code:

function seo_theme_content($content) {
	if (is_apache_module()) {
		$content = str_replace('href="?file=', 'href="'.SITE_URL.'/', $content);
		$content = str_replace('src="images/', 'src="'.SITE_URL.'/images/', $content);
	}
	return $content;
}

Inside seo.php file.

OK thanks.  This is the code that was in seo.php:

function seo_theme_content($content) {
	$content = str_replace('href="?file=', 'href="'.SITE_URL.'/', $content);
	$content = str_replace('src="images/', 'src="'.SITE_URL.'/images/', $content);

	return $content;
}

Changed code.
EDIT:  Just tried a new blog post and there is no change.  Not sure if this is relevant but different browsers handle this in different ways.  The icon for the missing image is shown by chrome, konqueror and epiphany, but is not shown by firefox or opera.

Last edited by miks (13-10-2011 09:14:48)

Offline

#4 13-10-2011 11:21:38

a_bach
developer/module guru
From: Poland
Registered: 24-11-2008
Posts: 439
Website

Re: Blog module affected by modified seo module

Ok - you dont need if (is_apache_module()) code, co you can remove it just it was.

This is new bug, never posted before. And I dont know how to fix it jet, I will need some time to check it.

For now the only way to show images in blog you will need to add full url to the image. Not images/name_of_image.jpg but http://treereportsandsurveys.co.uk/test … _image.jpg

This will show image. And i will test some code to fix it in the core.

A_Bach

Offline

#5 13-10-2011 11:36:56

a_bach
developer/module guru
From: Poland
Registered: 24-11-2008
Posts: 439
Website

Re: Blog module affected by modified seo module

Ok - I found it. This have to be fixed in blog module (not in the core as I fought).

You will need to add one line of code in two places in blog.site.php file. This line is:

run_hook('theme_content', array(&$post['content']));

Find //Check if we need to truncate text in blog_theme_main function, and add it under this line.
Now find echo $post['content'] in blog_page_site_viewpost() function and add it before.

First will fix problem on main blog page, second line will fix problem in post page.

A_Bach

Offline

#6 13-10-2011 13:23:13

miks
Member
Registered: 11-01-2009
Posts: 57
Website

Re: Blog module affected by modified seo module

OK, did that but no improvement.  The line of code appears twice before the blog text.
http://treereportsandsurveys.co.uk/test … e-function

Offline

#7 13-10-2011 13:24:49

miks
Member
Registered: 11-01-2009
Posts: 57
Website

Re: Blog module affected by modified seo module

This is my blog.site.php file:

 <?php
/*
 * This file is part of pluck, the easy content management system
 * Copyright (c) pluck team
 * http://www.pluck-cms.org

 * Pluck is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.

 * See docs/COPYING for the complete license.
*/

//Make sure the file isn't accessed directly.
defined('IN_PLUCK') or exit('Access denied!');

require_once ('data/modules/blog/functions.php');

function blog_pages_site() {
	global $lang;

	//Only get post title if post exists
	if (isset($_GET['post']) && blog_get_post($_GET['post'])) {
		include BLOG_POSTS_DIR.'/'.blog_get_post_filename($_GET['post']);
		$module_page_admin[] = array(
			'func'  => 'viewpost',
			'title' => $post_title
		);
	}

	//If post doesn't exist, make post title 404 error
	else {
		$module_page_admin[] = array(
				'func'  => 'viewpost',
				'title' => $lang['general']['404']
			);
	}

	return $module_page_admin;
}

function blog_theme_main($area, $category) {
	global $lang;

	//Display existing posts.
	if (blog_get_posts()) {
		//Load posts in array.
		$posts = blog_get_posts();

		//Get page number
		if (isset($_GET['p']) && is_numeric($_GET['p']))
			$page_no = $_GET['p'];
		else
			$page_no = 1;

		//Count posts.
		$post_number = 0;

		foreach ($posts as $post) {
			//Only show post if all categories should be shown, or if it's in the given category.
			if ($category == null || $category == $post['category']) {

				//Only display post if it's supposed to be on this page.
				if (($post_number >= ($page_no-1)*module_get_setting('blog','posts_per_page')) && ($post_number < $page_no*module_get_setting('blog','posts_per_page'))) {
				?>
				<div class="blog_post">
					<p class="blog_post_title">
						<a href="<?php echo PAGE_URL_PREFIX.CURRENT_PAGE_SEONAME.BLOG_URL_PREFIX.$post['seoname']; ?>" title="<?php echo $post['title']; ?>"><?php echo $post['title']; ?></a>
					</p>
					<span class="blog_post_info">
						<?php echo $post['date'].' '.$lang['blog']['at'].' '.$post['time'].' '.$lang['blog']['in'].' '.$post['category']; ?>
					</span>
					<div class="blog_post_content">
						<?php
						//Check if we need to truncate
						run_hook('theme_content', array(&$post['content']));
						if (module_get_setting('blog','truncate_posts') != '0')
							echo truncate($post['content'], module_get_setting('blog','truncate_posts'));
						else
							echo $post['content'];
						?>
					</div>
					<?php
					//If reactions are enabled, count reactions and display in 'read more'-link
					if (module_get_setting('blog','allow_reactions') == 'true') {
						$number = blog_get_reactions($post['seoname']);

						if ($number) {
							$number = count($number);

							if ($number == 1)
								$more_link = $number.' '.$lang['blog']['reaction'];
							else
								$more_link = $number.' '.$lang['blog']['reactions'];
						}
						else
							$more_link = $lang['blog']['no_reactions'];
					}
					//If reactions are disabled, display regular 'read more'-link
					else
						$more_link = $lang['blog']['read_more'];
					?>
					<p class="blog_post_more">
						<a href="<?php echo PAGE_URL_PREFIX.CURRENT_PAGE_SEONAME.BLOG_URL_PREFIX.$post['seoname']; ?>" title="<?php echo $more_link; ?>">&raquo; <?php echo $more_link; ?></a>
					</p>
				</div>
				<?php
				}
				$post_number++;
			}
		}
		unset($post);
	//Show page numbers
	echo '<p>'.$lang['blog']['pages'].' ';
	if ($category == null)
		blog_show_page_no_list($page_no);
	else
		blog_show_page_no_list($page_no, $category);
	echo '</p>';
	}
}

function blog_page_site_viewpost() {
	//Global language variables.
	global $lang;

	//Load blog post.
	if (isset($_GET['post']) && blog_get_post($_GET['post'])) {
		$post = blog_get_post($_GET['post']);
		?>
		<div id="blog_post">
			<span id="blog_post_info">
				<?php echo $post['date'].' '.$lang['blog']['at'].' '.$post['time'].' '.$lang['blog']['in'].' '.$post['category']; ?>
			</span>
			<div id="blog_post_content">
			run_hook('theme_content', array(&$post['content']));
				<?php echo $post['content']; ?>
			</div>
		</div>

		<?php
		//Check if reactions are enabled
		if (module_get_setting('blog','allow_reactions') == 'true') {
		?>
			<div id="blog_reactions">
				<p>
					<?php
					$number = blog_get_reactions($post['seoname']);

					if ($number) {
						$number = count($number);

						if ($number == 1)
							echo $number.' '.$lang['blog']['reaction'];
						else
							echo $number.' '.$lang['blog']['reactions'];
					}
					else
						echo $lang['blog']['no_reactions']
					?>
				</p>
				<?php
				$reactions = blog_get_reactions($_GET['post']);

				if ($reactions) {
					foreach ($reactions as $reaction) {
					?>
						<div class="blog_reaction" id="reaction<?php echo $reaction['id']; ?>">
							<p class="blog_reaction_name">
								<?php
								if (isset($reaction['website']))
									echo '<a href="'.$reaction['website'].'">'.$reaction['name'].'</a>:';
								else
									echo $reaction['name'].':';
								?>
							</p>
							<span class="blog_reaction_info">
								<a href="#reaction<?php echo $reaction['id']; ?>"><?php echo $reaction['date'].' '.$lang['blog']['at'].' '.$reaction['time']; ?></a>
						</span>
							<p class="blog_reaction_message"><?php echo $reaction['message']; ?></p>
						</div>
					<?php
					}
				}
				//If form is posted...
				if (isset($_POST['submit'])) {
					//Check if everything has been filled in.
					if (empty($_POST['blog_reaction_name']) || filter_input(INPUT_POST, 'blog_reaction_email', FILTER_VALIDATE_EMAIL) == false || (($_POST['blog_reaction_website'] != 'http://' && !empty($_POST['blog_reaction_website'])) && filter_input(INPUT_POST, 'blog_reaction_website', FILTER_VALIDATE_URL, FILTER_FLAG_HOST_REQUIRED) == false) || empty($_POST['blog_reaction_message']))
						echo '<p class="error">'.$lang['contactform']['fields'].'</p>';

					//Add reaction.
					else {
						blog_save_reaction($_GET['post'], $_POST['blog_reaction_name'], $_POST['blog_reaction_email'], $_POST['blog_reaction_website'], $_POST['blog_reaction_message']);

						//Redirect user.
							redirect(PAGE_URL_PREFIX.CURRENT_PAGE_SEONAME.BLOG_URL_PREFIX.$_GET['post'], 0);
					}
				}
				?>
				<form id="blog_post_form" method="post" action="">
					<div>
						<label for="blog_reaction_name"><?php echo $lang['general']['name']; ?></label>
						<br />
						<input name="blog_reaction_name" id="blog_reaction_name" type="text" />
						<br />
						<label for="blog_reaction_email"><?php echo $lang['general']['email']; ?></label>
						<br />
						<input name="blog_reaction_email" id="blog_reaction_email" type="text" />
						<br />
						<label for="blog_reaction_website"><?php echo $lang['general']['website']; ?></label>
						<br />
						<input name="blog_reaction_website" id="blog_reaction_website" type="text" value="http://" />
						<br />
						<label for="blog_reaction_message"><?php echo $lang['general']['message']; ?></label>
						<br />
						<textarea name="blog_reaction_message" id="blog_reaction_message" rows="7" cols="45"></textarea>
						<br />
						<input type="submit" name="submit" value="<?php echo $lang['general']['send']; ?>" />
					</div>
				</form>
			</div>

		<?php
		//End of commenting check.
		}
	}

	//If blog post doesn't exist, show 404 error.
	else
		echo $lang['general']['not_found'];
	?>
	<p>
		<a href="javascript: history.go(-1)" title="<?php echo $lang['general']['back']; ?>">&lt;&lt;&lt; <?php echo $lang['general']['back']; ?></a>
	</p>
	<?php
}
?>

Offline

#8 13-10-2011 19:45:35

a_bach
developer/module guru
From: Poland
Registered: 24-11-2008
Posts: 439
Website

Re: Blog module affected by modified seo module

Change

run_hook('theme_content', array(&$post['content']));
<?php echo $post['content']; ?>

into

<?php 
run_hook('theme_content', array(&$post['content']));
echo $post['content'];
?>

Offline

#9 13-10-2011 23:05:51

miks
Member
Registered: 11-01-2009
Posts: 57
Website

Re: Blog module affected by modified seo module

a_bach wrote:

Change

run_hook('theme_content', array(&$post['content']));
<?php echo $post['content']; ?>

into

<?php 
run_hook('theme_content', array(&$post['content']));
echo $post['content'];
?>

OK changed it but no difference.

EDIT:  I had forgotten to reset the seo.php file back to how it was as you requested.  I have done that now and it is working OK.

Last edited by miks (14-10-2011 08:54:26)

Offline

Pages: 1

Board footer

Powered by FluxBB

© 2005-2011 the pluck development team. pluck is available under the terms of the General Public License.